IRC Logs for #circuits-dev Saturday, 2013-02-09

mehereWell, look at manager.py:243. There ist says "if not channel_is_instance or channel == self:". "channel_is_instance" should actually be renamed to "channel_is_manager". So effectively, if the channel is a manager (i.e. component) the component's handlers are only considered (i.e. appended to the handlers_chain) if the current component (self) also happens to be the channel.04:36
prologicmehere, what did you wanted to change this behavior to?05:56
mehereI'd remove the condition in line 243. This does break 7 unit tests that need to be adapted, but anything else would only show that our unit tests are bad, because this does change the semantics...09:49
*** anunnaki has quit IRC22:23
*** anunnaki has joined #circuits-dev23:03

Generated by irclog2html.py 2.11.0 by Marius Gedminas - find it at mg.pov.lt!