prologic | yeah only thing that may be interferring is your environment | 00:01 |
---|---|---|
prologic | I'm not sure why your tracebacks are showing logilab :) | 00:01 |
prologic | also fyi | 00:01 |
prologic | tests run fine here | 00:01 |
prologic | running them locally now | 00:01 |
*** koobs has quit IRC | 05:15 | |
*** koobs has joined #circuits | 07:00 | |
*** treemo has joined #circuits | 07:30 | |
spaceone | prologic: ok, well then it is my environment... you can merge the PR now, as it successfully fails in TravisCI | 07:59 |
prologic | which PR? | 08:07 |
spaceone | prologic: the coroutine PR | 08:07 |
prologic | I merged em all :) | 08:08 |
prologic | let's see if we can focus our next efforts on getting all tests passing :) | 08:08 |
y0no | hum why pull request are merged whereas tests are broken on these commit ? | 10:07 |
prologic | y0no, because I merged it :) | 10:11 |
prologic | we can't be too strict right now | 10:11 |
prologic | because the tests aren't passing 100% | 10:11 |
prologic | :) | 10:11 |
prologic | so when they do (hopefully soon) we can get a little stricter on that | 10:11 |
prologic | :) | 10:11 |
prologic | it's as spaceone said the other day | 10:12 |
prologic | want to encourage easy contributions to the project | 10:12 |
prologic | not make it harder :) | 10:12 |
y0no | yep but the last commit (from treemo) introduce new issues (https://travis-ci.org/circuits/circuits) that needed to be fixed before merged | 10:17 |
y0no | when we do a pull request we have the result of the travis CI tests, I think it's better to fix new issue before merging it no ? | 10:18 |
prologic | spaceone, https://travis-ci.org/circuits/circuits/jobs/62212231 | 10:33 |
prologic | exec in | 10:33 |
prologic | This doesn't work with Python 3.2 | 10:33 |
prologic | y0no, I completely agree :) | 10:33 |
spaceone | prologic: trying again | 11:46 |
prologic | yeah yeah :) | 11:51 |
prologic | nps | 11:51 |
*** Romster has quit IRC | 16:53 | |
*** Romster has joined #circuits | 16:53 | |
*** treemo has quit IRC | 17:48 | |
*** treemo has joined #circuits | 18:02 | |
*** tariq786 has quit IRC | 18:15 | |
*** treemo has quit IRC | 18:27 | |
*** treemo has joined #circuits | 18:42 | |
*** treemo has quit IRC | 19:23 | |
spaceone | prologic: since when are event names case sensitive? | 21:40 |
prologic | since always! | 23:22 |
prologic | haha | 23:22 |
prologic | I think :) | 23:22 |
spaceone | okay, well does not matter | 23:36 |
spaceone | prologic: is there some tool to add a timeout for a event? | 23:37 |
spaceone | prologic: wow, the inherited __nonzero__/__bool__ method from BaseComponent was very irritating and costed a lot of time to debug... if foo: → false; if foo is not None: → true | 23:39 |
Generated by irclog2html.py 2.11.0 by Marius Gedminas - find it at mg.pov.lt!