IRC Logs for #circuits Wednesday, 2015-05-13

prologicspaceone: Yeah I'm not really sure we really need that00:09
prologicit *was* designed for the use-case of00:09
prologicif app:00:09
prologic   ...00:09
prologicwhere it would be True if the event queue had events00:09
prologicI think00:09
prologicI think it *is* used internalyl though00:10
prologicbut could be replaced00:10
prologicre timeout for an event00:10
prologicwhat do you mean by that?00:10
*** treemo has joined #circuits07:30
spaceoneprologic: self.wait() with timeout... maximum wait 1 second otherwise stop that event07:33
spaceoneprologic: FYI: i am afk until saturday07:33
prologicoh we have that already I believe08:09
prologicbut it's not 1s per say08:09
prologicI think it's no. of ticks08:09
prologicor something08:09
prologiccan't quite remember08:09
prologicwhat does the docstring say? :)08:10
spaceoneprologic: does manager.stop() block until all events like 'stoppped'/etc. are performed?08:25
prologicspaceone, yes08:28
prologicbut it's better to raise SystemExit()08:28
prologicsince that's caught by the manager08:28
prologicand handled gracefully08:28
spaceoneare there differences then?08:29
spaceoneprologic: your commit is the same...08:33
spaceoneprologic: there is no try: except: (did you push the fixup correctly)?08:46
prologicdamnit09:01
prologiclemme check :)09:01
prologicspaceone, lol09:02
prologicforgot git add -A09:02
prologicdone and pushed up09:02
prologicthere we go :)09:02
spaceoneprologic: i'll change a little bit in droppriviledges in the evening09:10
prologicsure feel free09:23
prologicit's a branch on the circuits repo itself09:23
prologicwhat are you proposing?09:23
*** irclogger_ has joined #circuits09:27
spaceoneprologic: https://github.com/spaceone/circuits/commit/a158cddffe5ed75639793d9b89bf87788ce9033709:33
spaceonegr, tab/space mix09:33
spaceonehttps://github.com/spaceone/circuits/commit/442ae7a6191680fc7dadaf4988a42252acf5204009:35
prologichmm09:38
prologici see where you're going with this09:38
prologicbut tbqh I don't think semantically it makes much difference here09:38
prologicright?09:38
spaceonewell, Exception will catch a lot things, e.g. SyntaxError...09:41
prologicwell that'll never be caught there09:58
prologicas it's caught higher up :)09:58
prologicin the event dispatcher :)09:58
spaceoneno10:19
spaceoneit would be10:19
spaceonewhen using except Exception10:19
*** FSX has quit IRC10:26
prologichmm?10:28
prologicthat's what I'm trying to say though10:28
prologicthe dispatcher has a try/except10:28
prologicoh wait10:28
prologichmm10:28
prologicyes you're right10:28
prologicyeah happy to go with your improved PR10:28
*** koobs has quit IRC10:34
*** Romster has quit IRC10:35
*** FSX has joined #circuits10:37
*** Romster has joined #circuits10:42
*** koobs has joined #circuits11:53
*** tariq786 has joined #circuits14:35
*** treemo has quit IRC15:20
*** treemo has joined #circuits15:32
*** treemo has quit IRC16:50
*** treemo has joined #circuits17:07
*** treemo has quit IRC18:14
*** treemo has joined #circuits19:56
*** treemo has quit IRC22:45

Generated by irclog2html.py 2.11.0 by Marius Gedminas - find it at mg.pov.lt!