IRC Logs for #circuits Wednesday, 2016-11-02

*** ke4roh has joined #circuits00:47
spaceoneriot: you mean because socket.read(BUFSIZE) causes that if the content is longer than bufsize there are two events fired ?00:54
spaceone(or one is chocked)00:54
riotsomething along that line, i assume, yeah.01:36
rioti haven't fired wireshark up yet and the browser console doesn't tell me anything about websocket transmissions, only the connection upgrades at the beginning.01:37
riotbut it closely matches the packet boundary size where i noticed this to start failing01:37
*** ke4roh has quit IRC01:43
*** Workster has quit IRC03:22
*** dbjfvewgepkmxnny has joined #circuits03:22
*** Workster has joined #circuits03:22
*** Romster has quit IRC07:14
*** Romster has joined #circuits07:56
*** Romster has quit IRC08:36
*** Romster has joined #circuits08:55
*** Romster has quit IRC09:25
*** Romster has joined #circuits09:53
*** Romster has quit IRC10:27
*** Romster has joined #circuits11:15
*** Romster has quit IRC11:46
*** Romster has joined #circuits11:47
*** Romster has quit IRC11:55
*** Romster has joined #circuits12:44
*** ke4roh has joined #circuits12:54
spaceoneriot: do you have an reproducible example?15:15
riotspaceone: yes. Its on github: https://github.com/ri0t/websocketdebugger16:32
riotnot sure why i made it that way, but the number you enter there is 2^X16:32
riotso, with X>12 it breaks16:32
*** qwebirc95518 has joined #circuits18:45
qwebirc95518how do I set the timeout for a response in circuits?18:52
*** ke4roh has quit IRC20:05
*** ke4roh has joined #circuits20:22
spaceoneqwebirc95518: what do you mean with response?21:25
spaceonecircuits.web ?21:25
spaceoneas http client?21:25
spaceoneor server?21:26
spaceoneor general sockets?21:26
spaceonethere is nothing generic. i implemented this for circuits.http, i think you can steal this21:27
spaceoneriot: i need to enter a number > 1096 ?21:32
spaceoneriot: i need to enter a number > 4096 ?21:33
qwebirc95518spaceone: yeah http server, the web server21:40
spaceoneqwebirc95518: https://github.com/spaceone/circuits.http/blob/master/circuits/http/server/server.py#L10521:41
spaceoneyou might rip/copy the methods21:42
spaceoneand adapt them to circuits.web21:43
qwebirc95518spaceone: thanks a lot.21:48
*** Romster has quit IRC22:00
*** ke4roh has quit IRC22:01
*** ke4roh has joined #circuits22:20
GitHub132[circuits] spaceone created fix_websockets_buffer_overflow_issue_181 (+1 new commit): https://git.io/vXZBa22:24
GitHub132circuits/fix_websockets_buffer_overflow_issue_181 1a7a076 SpaceOne: Fix websocket data parsing if content is larger than read BUFSIZE; Issue #18122:24
GitHub57[circuits] spaceone opened pull request #184: Fix websocket data parsing if content is larger than read BUFSIZE; Is… (master...fix_websockets_buffer_overflow_issue_181) https://git.io/vXZBD22:25
spaceoneriot: i fixed your problem22:29
GitHub93[circuits] spaceone pushed 1 new commit to fix_websockets_buffer_overflow_issue_181: https://git.io/vXZEg22:46
GitHub93circuits/fix_websockets_buffer_overflow_issue_181 1ac3e92 SpaceOne: Add test for websocket response with request larger than read BUFSIZE22:46
*** qwebirc95518 has quit IRC22:51
spaceoneprologic: is it possible that you deactivate your email signature when answering to github issues?22:57
spaceoneor mark it as a real email signature23:05
spaceoneotherwise it is always added to the test and is really much disturbing and time wasting23:05
*** Romster has joined #circuits23:14
*** travis-ci has joined #circuits23:26
travis-cicircuits/circuits#495 (fix_websockets_buffer_overflow_issue_181 - 1a7a076 : SpaceOne): The build has errored.23:26
travis-ciChange view : https://github.com/circuits/circuits/commit/1a7a076223e823:26
travis-ciBuild details : https://travis-ci.org/circuits/circuits/builds/17278012923:26
*** travis-ci has left #circuits ()23:26
*** Romster has quit IRC23:32
*** Romster has joined #circuits23:42

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!