IRC Logs for #circuits Friday, 2016-11-04

*** riot has joined #circuits00:11
riotoh. re00:11
riotspaceone: hmm, thanks for your efforts, but here, the error persists :.(00:12
spaceoneriot: try harder00:18
spaceonedid you checkout this branch?00:19
spaceoneit works perfectly for me00:19
spaceonein python300:19
spaceonewith your github repo00:19
riothmm. perhaps some setuptool-stupidity.. hmm00:26
riothmm, indeed, it doesn't fail at 4096 bytes, but try doubling that ;>00:33
riotresults in "json.decoder.JSONDecodeError: Invalid control character at: line 1 column 4089 (char 4088)00:34
riotvery weird00:34
spaceonei will take a look at the weekend00:35
riotcool :D00:35
spaceonewhat number dud you use?00:37
spaceone24 ?00:37
riot13 already fails00:38
riotactually, i first real-life-tested with a larger lorem ipsum text page in HFOS, then as per your suggestion did the test with 2^13 bytes in the websocketdebugger00:39
riot(50k of lorem ipsum is a lot of latin)00:39
*** ke4roh__ has joined #circuits00:40
*** ke4roh__ has quit IRC00:49
spaceoneriot: got it00:50
spaceone-                self._buffer += data00:50
spaceone+                self._buffer = data00:50
spaceoneriot: pushed the fix00:53
GitHub51[circuits] spaceone force-pushed fix_websockets_buffer_overflow_issue_181 from 1ac3e92 to 5290d8c:
GitHub51circuits/fix_websockets_buffer_overflow_issue_181 259c7e5 SpaceOne: Fix websocket data parsing if content is larger than read BUFSIZE; Issue #18100:53
GitHub51circuits/fix_websockets_buffer_overflow_issue_181 5290d8c SpaceOne: Add test for websocket response with request larger than read BUFSIZE00:53
riotthanks a lot!00:54
spaceonei don't receive an answer for '31'00:55
spaceonemaybe it just takes too long :D:D00:55
spaceoneit is 31^2 bytes, right?00:55
riotthat is 2 GB ;D00:57
riotbut yeah, you're right. In theory, that should work as well. According to websocket, the upper limit is 2^64, iirc.00:57
*** ke4roh has joined #circuits00:58
spaceonedo you have more problems?00:58
riotnot with circuits, atm :>00:59
riotthe javascript side on my project is way more fidgety.. must be the language.00:59
spaceoneyes, javascript is puke01:00
spaceoneriot: where can i see the actual websocket code?01:01
spaceonesomewhere in ?01:01
riot..but its getting better. Yep, here:
riotits probably full of fleas etc. More in a prototype state right now.01:02
rioti.e. no security hardening, optimizations etc01:02
spaceonegr, except Exception → is the worst thing one can do :/01:03
riotyes. I should fix those. There are a lot of them, from a time when i was still fighting circuits' debugger.01:04
spaceonei'm going to sleep, good night01:04
*** travis-ci has joined #circuits01:28
travis-cicircuits/circuits#499 (fix_websockets_buffer_overflow_issue_181 - 5290d8c : SpaceOne): The build has errored.01:28
travis-ciChange view :
travis-ciBuild details :
*** travis-ci has left #circuits ()01:28
*** Osso has quit IRC01:38
*** Osso has joined #circuits02:01
*** Osso_ has joined #circuits02:17
*** Osso_ has quit IRC02:49
*** Romster has quit IRC03:08
*** Romster has joined #circuits03:11
*** ke4roh has quit IRC04:15
*** Osso has quit IRC04:53
GitHub119[circuits] prologic closed pull request #184: Fix websocket data parsing if content is larger than read BUFSIZE; Is… (master...fix_websockets_buffer_overflow_issue_181)
GitHub41[circuits] prologic pushed 1 new commit to master:
GitHub41circuits/master 3ec4b32 ⁣ Florian Best: Fix websocket data parsing if content is larger than read BUFSIZE; Is… (#184)...06:32
*** riot has quit IRC07:26
*** ke4roh has joined #circuits07:38
*** ke4roh has quit IRC07:51
*** ke4roh has joined #circuits07:56
*** spaceone has quit IRC09:17
*** spaceone has joined #circuits09:52
*** riot has joined #circuits10:26
GitHub30[circuits] spaceone deleted fix_websockets_buffer_overflow_issue_181 at 5290d8c:
*** ke4roh has quit IRC11:24
*** ke4roh has joined #circuits12:16
*** ke4roh has quit IRC12:56
*** ke4roh has joined #circuits13:05
*** Osso has joined #circuits13:23
*** Osso_ has joined #circuits16:36
*** Osso_ has quit IRC17:06
*** Osso has quit IRC17:44
*** Osso has joined #circuits17:48
*** mmlj4 has joined #circuits19:35
*** ke4roh has quit IRC20:53
*** ke4roh has joined #circuits21:01
*** ke4roh has quit IRC21:40
*** Osso has quit IRC22:00
*** mmlj4 has left #circuits ("Leaving")22:52

Generated by 2.14.0 by Marius Gedminas - find it at!