IRC Logs for #circuits Friday, 2017-01-27

spaceoneprologic: what do you think about my starttls PR?12:07
*** FSX has quit IRC12:16
*** ke4roh has joined #circuits13:35
GitHub148[circuits] apollo13 pushed 1 new commit to master: https://git.io/vDfvh14:58
GitHub148circuits/master 7443fb9 Florian Apolloner: Fixed #198 -- Made pushing onto the event queue via fire threadsafe.14:58
GitHub121[circuits] apollo13 closed pull request #209: [WIP] Issue198 (master...issue198) https://git.io/vM7f114:58
*** travis-ci has joined #circuits15:38
travis-cicircuits/circuits#640 (master - 7443fb9 : Florian Apolloner): The build passed.15:38
travis-ciChange view : https://github.com/circuits/circuits/compare/25442fccf723...7443fb9ee1f415:38
travis-ciBuild details : https://travis-ci.org/circuits/circuits/builds/19589721815:38
*** travis-ci has left #circuits ()15:38
apollo13riot: around?15:44
GitHub181[circuits] apollo13 opened pull request #216: [WIP] Speed up tests by using less threading. (master...test_speedup) https://git.io/vDfLu15:49
apollo13prologic: what about speeding up tests like this: https://github.com/circuits/circuits/pull/216 :D15:51
*** ke4roh_ has joined #circuits16:02
*** ke4roh has quit IRC16:04
GitHub145[circuits] apollo13 opened pull request #217: [WIP] try to find the test failures in the process stuff. (master...test_failures) https://git.io/vDf3t16:22
*** ke4roh__ has joined #circuits17:06
*** ke4roh_ has quit IRC17:09
apollo13prologic, spaceone: can anyone explain what is happening here https://travis-ci.org/circuits/circuits/jobs/195932265#L641 ?17:54
apollo13shit I shouldn't have restarted the build, that nukes the output :(18:06
apollo13basically test_value_notify failed in assert watcher.wait("hello_value_changed")18:06
apollo13according to the debugger hello got fired, but never the changed thinfy18:06
apollo13ok, https://travis-ci.org/circuits/circuits/jobs/195932265 failed again :)18:12
*** ke4roh_ has joined #circuits18:12
*** ke4roh__ has quit IRC18:15
spaceonethe watcher thing is strange18:29
spaceonenot easy to debug18:29
spaceoneand one must be carfeul with clear()18:29
apollo13spaceone: there is no clear to the best of my knowledge and the debugger seems to indicate that the value didn't even get fired18:30
apollo13s/value/event/18:31
spaceoneapollo13: you can git ci --amend to append to the last commit and force push with git push remotename +branchname18:54
apollo13spaceone: I know, but for test stuff like that I am too lazy :D18:55
spaceoneokay :D18:55
apollo13also for forced pushes I do miss the travis <> github assoc18:55
apollo13loose rather18:55
apollo13now pleeeeeeeeeeeeeeeeeeeeeease fail again :D18:55
apollo13spaceone: stupid idea, with threading and everything (especially the GIL), could it be that x.notify = True is just set to late?19:16
apollo13ha, that might be it19:17
apollo13if I put a sleep in there I get consistend failures locally19:18
apollo13but only if I sleep long enough19:19
GitHub61[circuits] apollo13 closed pull request #217: [WIP] try to find the test failures in the process stuff. (master...test_failures) https://git.io/vDf3t19:26
*** ke4roh__ has joined #circuits19:26
GitHub55[circuits] apollo13 created fixed_threading (+1 new commit): https://git.io/vDfPI19:28
GitHub55circuits/fixed_threading bac760a Florian Apolloner: Fixed race condition in test_value.py...19:28
GitHub91[circuits] apollo13 opened pull request #218: Fixed race condition in test_value.py (master...fixed_threading) https://git.io/vDfPt19:28
*** ke4roh_ has quit IRC19:29
spaceoneapollo13: hmm this looks strange19:29
apollo13spaceone: how so?19:29
spaceonethe main event loop runs in another thread?19:29
GitHub156[circuits] apollo13 pushed 1 new commit to fixed_threading: https://git.io/vDfPz19:29
GitHub156circuits/fixed_threading 0f19300 Florian Apolloner: Finish travis builds early (ie before allowed_failures are finished).19:29
apollo13spaceone: yes19:30
spaceonehmm okay19:30
apollo13spaceone: at least during those tests19:30
spaceoneyes19:30
apollo13see conftest.py and the definition of manager there19:30
spaceoneit's the design of these tests19:30
apollo13then I do not understand your question :D19:30
spaceonemaybe it's not good that the tests run in a thread while the real life things run without19:30
apollo13well for a few things it is the easiest way to test that19:31
apollo13for now I just want to get the tests stable (tm)19:31
apollo13then we can fix them to work without threads were possible19:31
apollo13but that will require more work19:31
spaceonemaybe it is also good that they run in a thread :D19:32
spaceonethen we notice such things19:33
spaceonethis is syntax which shouldn't be used then19:33
apollo13yeah, more or less :D19:33
apollo13can you ack the PR so I can merge later?19:33
spaceonemaybe introducing **kwargs for fire() can set those values19:33
spaceoneyes19:33
apollo13jupp, wanna open a ticket for that?19:34
spaceonei can19:34
apollo13:thumbs_up:19:34
spaceonehttps://github.com/circuits/circuits/issues/21919:38
apollo13sounds good19:40
*** travis-ci has joined #circuits21:01
travis-cicircuits/circuits#653 (fixed_threading - 0f19300 : Florian Apolloner): The build passed.21:01
travis-ciChange view : https://github.com/circuits/circuits/compare/bac760a2f6db...0f1930011a3921:01
travis-ciBuild details : https://travis-ci.org/circuits/circuits/builds/19597950821:01
*** travis-ci has left #circuits ()21:01
GitHub142[circuits] apollo13 closed pull request #218: Fixed race condition in test_value.py (master...fixed_threading) https://git.io/vDfPt21:02
GitHub103[circuits] apollo13 pushed 2 new commits to master: https://git.io/vDfFt21:02
GitHub103circuits/master 6c6ed43 Florian Apolloner: Fixed race condition in test_value.py...21:02
GitHub103circuits/master ebc2e4a Florian Apolloner: Finish travis builds early (ie before allowed_failures are finished).21:02
GitHub181[circuits] apollo13 deleted fixed_threading at 0f19300: https://git.io/vDfFq21:02
*** travis-ci has joined #circuits21:03
travis-cicircuits/circuits#653 (fixed_threading - 0f19300 : Florian Apolloner): The build passed.21:03
travis-ciChange view : https://github.com/circuits/circuits/compare/bac760a2f6db...0f1930011a3921:03
travis-ciBuild details : https://travis-ci.org/circuits/circuits/builds/19597950821:03
*** travis-ci has left #circuits ()21:03
*** travis-ci has joined #circuits21:07
travis-cicircuits/circuits#653 (fixed_threading - 0f19300 : Florian Apolloner): The build passed.21:07
travis-ciChange view : https://github.com/circuits/circuits/compare/bac760a2f6db...0f1930011a3921:07
travis-ciBuild details : https://travis-ci.org/circuits/circuits/builds/19597950821:07
*** travis-ci has left #circuits ()21:07
*** travis-ci has joined #circuits21:11
travis-cicircuits/circuits#654 (master - ebc2e4a : Florian Apolloner): The build was broken.21:11
travis-ciChange view : https://github.com/circuits/circuits/compare/7443fb9ee1f4...ebc2e4a6c7db21:11
travis-ciBuild details : https://travis-ci.org/circuits/circuits/builds/19600358021:11
*** travis-ci has left #circuits ()21:11
*** travis-ci has joined #circuits21:45
travis-cicircuits/circuits#654 (master - ebc2e4a : Florian Apolloner): The build passed.21:45
travis-ciChange view : https://github.com/circuits/circuits/compare/7443fb9ee1f4...ebc2e4a6c7db21:45
travis-ciBuild details : https://travis-ci.org/circuits/circuits/builds/19600358021:45
*** travis-ci has left #circuits ()21:45
*** ke4roh_ has joined #circuits21:48
*** ke4roh__ has quit IRC21:51
*** ke4roh_ has quit IRC21:51
*** travis-ci has joined #circuits22:10
travis-cicircuits/circuits#653 (fixed_threading - 0f19300 : Florian Apolloner): The build passed.22:10
travis-ciChange view : https://github.com/circuits/circuits/compare/bac760a2f6db...0f1930011a3922:10
travis-ciBuild details : https://travis-ci.org/circuits/circuits/builds/19597950822:10
*** travis-ci has left #circuits ()22:10
*** ke4roh has joined #circuits22:17
*** travis-ci has joined #circuits22:20
travis-cicircuits/circuits#654 (master - ebc2e4a : Florian Apolloner): The build passed.22:20
travis-ciChange view : https://github.com/circuits/circuits/compare/7443fb9ee1f4...ebc2e4a6c7db22:20
travis-ciBuild details : https://travis-ci.org/circuits/circuits/builds/19600358022:20
*** travis-ci has left #circuits ()22:20
*** ke4roh has quit IRC22:21
*** travis-ci has joined #circuits22:23
travis-cicircuits/circuits#654 (master - ebc2e4a : Florian Apolloner): The build passed.22:23
travis-ciChange view : https://github.com/circuits/circuits/compare/7443fb9ee1f4...ebc2e4a6c7db22:23
travis-ciBuild details : https://travis-ci.org/circuits/circuits/builds/19600358022:23
*** travis-ci has left #circuits ()22:23
*** travis-ci has joined #circuits22:24
travis-cicircuits/circuits#654 (master - ebc2e4a : Florian Apolloner): The build passed.22:24
travis-ciChange view : https://github.com/circuits/circuits/compare/7443fb9ee1f4...ebc2e4a6c7db22:24
travis-ciBuild details : https://travis-ci.org/circuits/circuits/builds/19600358022:24
*** travis-ci has left #circuits ()22:24
*** FSX has joined #circuits22:30
*** travis-ci has joined #circuits22:52
travis-cicircuits/circuits#654 (master - ebc2e4a : Florian Apolloner): The build passed.22:52
travis-ciChange view : https://github.com/circuits/circuits/compare/7443fb9ee1f4...ebc2e4a6c7db22:52
travis-ciBuild details : https://travis-ci.org/circuits/circuits/builds/19600358022:52
*** travis-ci has left #circuits ()22:52
*** travis-ci has joined #circuits22:54
travis-cicircuits/circuits#654 (master - ebc2e4a : Florian Apolloner): The build passed.22:54
travis-ciChange view : https://github.com/circuits/circuits/compare/7443fb9ee1f4...ebc2e4a6c7db22:54
travis-ciBuild details : https://travis-ci.org/circuits/circuits/builds/19600358022:54
*** travis-ci has left #circuits ()22:54
*** travis-ci has joined #circuits22:56
travis-cicircuits/circuits#654 (master - ebc2e4a : Florian Apolloner): The build passed.22:56
travis-ciChange view : https://github.com/circuits/circuits/compare/7443fb9ee1f4...ebc2e4a6c7db22:56
travis-ciBuild details : https://travis-ci.org/circuits/circuits/builds/19600358022:56
*** travis-ci has left #circuits ()22:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!