| *** robert_|disconne has quit IRC | 02:42 | |
| *** robert_|disconne has joined #circuits | 02:42 | |
| *** ke4roh has joined #circuits | 13:28 | |
| *** chrismay has joined #circuits | 14:25 | |
| spaceone | ke4roh: I answered to your stackoverflow question | 14:28 |
|---|---|---|
| ke4roh | spaceone: thanks! | 14:28 |
| ke4roh | ACTION reads to catch up... | 14:29 |
| spaceone | ke4roh: for fetching 2 urls at the same time: maybe it helps to create a new event and fire this instead where you fetch and fire all events after another | 14:30 |
| spaceone | maybe there is also something wrong in circuits.web.client which prevents this | 14:30 |
| spaceone | dunno | 14:30 |
| ke4roh | spaceone: I'm pretty sure there is. | 14:30 |
| spaceone | ACTION doesn't use circuits.web | 14:31 |
| spaceone | so i don't really know | 14:31 |
| ke4roh | spaceone: I was working on a workaround using a Worker and urllib3, but Manager.wait(event,channel) appears to block if the event is already complete when the call to wait is made. | 14:32 |
| ke4roh | I can also write a test for that... | 14:32 |
| spaceone | would be nice | 14:34 |
| spaceone | i had issues with that before, too | 14:34 |
| spaceone | waiting for already finished events | 14:34 |
| *** ke4roh_ has joined #circuits | 14:42 | |
| *** ke4roh has quit IRC | 14:45 | |
| ke4roh | spaceone: ah, yes, issue #182 | 14:57 |
| ke4roh | spaceone: although your patch just makes it so you can wait on multiples, not so that you can wait on one that has already finished. | 14:59 |
| ke4roh | I will see what I can do about one that is finished. | 14:59 |
| spaceone | ke4roh: i don't understand how it can be finished in your example | 15:01 |
| spaceone | becuase you are just self.fire() twice | 15:01 |
| spaceone | ah | 15:01 |
| spaceone | so the second wait doesn't work anymore | 15:01 |
| ke4roh | spaceone: right. If I fire, fire, wait, wait, then the second wait always (so far) blocks forever (or until timeout) | 15:02 |
| ke4roh | and I can't even catch the timeout from around the yield! | 15:02 |
| spaceone | yes | 15:03 |
| *** apollo13 has quit IRC | 15:19 | |
| *** ke4roh_ has joined #circuits | 15:19 | |
| *** apollo13 has joined #circuits | 15:20 | |
| ke4roh_ | spaceone: I'm having a devil of a time introducing a new test. I run test_call_wait.py, which passes, then I add a new function test_wait_too_late(manager,watcher, app) at the end... | 17:05 |
| ke4roh_ | spaceone: and then it complains TypeError: test_wait_too_late() missing 3 required positional arguments: 'manager', 'watcher', and 'app' | 17:05 |
| ke4roh_ | but I am probably missing something magic about pytest. | 17:05 |
| ke4roh_ | and google and grep are failing me at the moment. | 17:05 |
| spaceone | ke4roh: just add these arguments to the function | 17:11 |
| spaceone | these are fixtures from conftest.py | 17:11 |
| spaceone | ke4roh: hm.. please send me the diff | 17:12 |
| ke4roh | https://gist.github.com/ke4roh/24bdbf01983a4cf08d9bb351b75d4979 | 17:15 |
| ke4roh | spaceone: that's not the finished test - it will hang if it does as I suspect. | 17:15 |
| ke4roh | I need to wrap it with a timeout that will fail rather quickly anyhow. | 17:15 |
| ke4roh | but I wanted to see *something* happen, and I was surprised by what I saw. | 17:16 |
| spaceone | ke4roh: probably this happens because of the yield | 17:22 |
| spaceone | this won't be a coroutine if you yield inside of it | 17:22 |
| spaceone | because it is no @handler() | 17:22 |
| spaceone | ke4roh: instead if yield you can use app.ticket() or something like this | 17:23 |
| spaceone | or manager.tick() | 17:24 |
| spaceone | not sure | 17:24 |
| ke4roh | spaceone: you're right that it is because of the yield. I took out both yields and the test ran correctly. | 17:24 |
| spaceone | ke4roh: the test looks working nice. you could do a @pytest.mark.xfail() and submit a pull request | 18:07 |
| spaceone | @pytest.mark.xfail(reason='Issue #226') | 18:08 |
| kdb | Unknown Command: pytest.mark.xfail(reason='issue | 18:08 |
| *** ke4roh_ has joined #circuits | 18:32 | |
| *** nizox has quit IRC | 20:45 | |
| GitHub153 | [circuits] ke4roh opened pull request #227: Write a test for issue 226 (master...issue226) https://git.io/vDMdy | 20:46 |
| spaceone | nice :) kdb | 20:51 |
| GitHub76 | [circuits] spaceone pushed 1 new commit to master: https://git.io/vDMxJ | 21:11 |
| GitHub76 | circuits/master 1b69122 Jim Scarborough: Write a test for issue #226... | 21:11 |
| GitHub120 | [circuits] spaceone closed pull request #227: Write a test for issue 226 (master...issue226) https://git.io/vDMdy | 21:11 |
| *** chrismay has quit IRC | 21:19 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!