IRC Logs for #circuits Wednesday, 2018-06-20

*** cfelton has joined #circuits05:27
*** cfelton has quit IRC05:56
*** kromg has joined #circuits06:13
*** kromg2 has quit IRC06:14
*** jxjtnpodpfvxhrdm has joined #circuits06:17
*** Workster has quit IRC06:17
*** Workster has joined #circuits06:17
*** cfelton has joined #circuits06:18
*** abcerr has joined #circuits08:00
*** spaceone has joined #circuits08:55
*** abcerr has quit IRC09:18
*** abcerr has joined #circuits09:26
*** abcerr has quit IRC09:58
GitHub18[circuits] ri0t opened pull request #241: Fixed API call to networkx (master...patch-2) https://git.io/fZb1P14:22
GitHub110[circuits] prologic pushed 1 new commit to master: https://git.io/fnR0i14:47
GitHub110circuits/master 30c9eba riot: Fixed API call to networkx (#241)...14:47
GitHub99[circuits] prologic closed pull request #241: Fixed API call to networkx (master...patch-2) https://git.io/fZb1P14:47
riotprologic: that leaves the old ones listening for events which screws everything up. I am trying to delete them, but apparently circuits.core.manager keeps a reference around, so they don't get killed by the GC15:05
prologicumm15:06
prologicthat's a bug then15:06
prologic.unregister() should remove all event handlers from the component15:06
prologicand circuits.core.utils.kill() does .unregister() recursively15:07
rioti dug around somewhat by using objgraph to get to references, saw and killed a few of my own but there's this one ref to a dict called "manager" - i am just assuming this is circuits.core.manager. Can upload the graph, if you want to make sure15:07
prologicoh wait15:28
prologicyou mean the component itself still has a refe to the root manager?15:28
prologic.unregister() should probably set it to itself as it's no longer part of the root manager tree15:28
prologicit *is* possible to have multiple component graphs running with their own manager(s)15:28
prologicseems like an easy fix if that's why we're not doing?15:29
GitHub118[circuits] kromg opened pull request #242: Added PY2 to imports in values.py (master...fix_values_missing_import) https://git.io/fnRrr15:53
GitHub147[circuits] prologic closed pull request #242: Added PY2 to imports in values.py (master...fix_values_missing_import) https://git.io/fnRrr15:55
GitHub39[circuits] prologic pushed 1 new commit to master: https://git.io/fnRrQ15:55
GitHub39circuits/master af570fa Giacomo Montagner: Added PY2 to imports in values.py (#242)15:55
*** kromg2 has joined #circuits17:19
*** kromg has quit IRC17:22
*** abcerr has joined #circuits22:25
*** abcerr has quit IRC22:31

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!